Remove firebaseToken from persistence if tokenRefreshHandler is not s… #9298
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et and token is expired
mansisampat
requested review from
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
NhienLam and
a team
as code owners
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
pashanka
reviewed
Oct 7, 2025
| } | ||
|
|
||
| // Resets the Firebase Access Token to null i.e. logs out the user. | ||
| await this._updateFirebaseToken(null); |
There was a problem hiding this comment.
Should we call signOut here? I see that signOut does few extra steps. Also probably this can go in the else part as if tokenRefreshHandler is present we should not be signing out.
There was a problem hiding this comment.
Correct, we can call the signOut method instead.
Also probably this can go in the else part as if
tokenRefreshHandleris present we should not be signing out.
If tokenRefreshHandler is present and returns a successful response we are doing an exchangeToken that essentially logs in the user. Hence having signOut would have been a no-op.
That said I have moved the signOut towards the end of the function to avoid confusion.
pashanka
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove firebaseToken from persistence if tokenRefreshHandler is not set and token is expired
Testing